More extensive use of omitempty #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "omitempty" for attributes where "use" is default (optional). Add "omitempty" for elements where minOccurs=0 Minor cleanups in the Makefile. Add XML un/marshal test for the example schema.
|
@isimluk any chance to get this reviewed? This is especially problematic when the schema includes optional datetime elements for which "empty" is not a correct value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "omitempty" for attributes where "use" is empty (as it defaults to "optional" per XSD spec).
Add "omitempty" for elements where minOccurs=0
Minor cleanups in the Makefile, add targets to generate schema for XML testing.
Add XML un/marshal test for the example schemas: namespace changes in the test schemas are merely to avoid collisions when pre-generating Go structs. Only one test for "complex" added, more can be added later.