[REFAX] Refactored function calls at close socket for preparing a change

[ethouris]

No description provided.

[maxsharabayko]

Extracted from #1829.

[ethouris]

Careful. This last fix has caused tests to crash.

[ethouris]

Now the refax should be ok, but all attempts to provide a reliable closing a socket have failed, so this refax is useless.

[maxsharabayko]

I am concerned with this function because it provides not much hints of what it does internally.
It notably comes from the overall mess with socket lifetime management.

There is m_ClosedSockets for sockets to be closed and m_Sockets for active sockets.
A socket can sometimes be present in both lists for a short time.
swipeSocket_LOCKED(i->first, s, SWIPE_LATER) with SWIPE_LATER is only used in checkBrokenSockets(..). All other places use SWIPE_NOW. Does it make sense to have a function that does both?

newConnection error, srt_close, removeSocket -> SWIPE_NOW.
checkBrokenSockets(..), srt_cleanup -> SWIPE_LATER.

[ethouris]

The SWIPE_NOW and SWIPE_LATER differ only with that when SWIPE_LATER is used, then the call will be followed by a loop that will delete all sockets that were collected in the temporary list. So the socket being worked about at this call need not be swiped at this moment.

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (45232ad) 66.50% compared to head (b5dd5a5) 66.22%.
Report is 126 commits behind head on master.

❗ Current head b5dd5a5 differs from pull request most recent head ed1e8d0. Consider uploading reports for the commit ed1e8d0 to get more accurate results

Files	Patch %	Lines
srtcore/api.cpp	89.47%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2639      +/-   ##
==========================================
- Coverage   66.50%   66.22%   -0.29%     
==========================================
  Files          99       99              
  Lines       19820    19848      +28     
==========================================
- Hits        13182    13144      -38     
- Misses       6638     6704      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.