[tests] Enable hlc tests on windows and mac #11768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for a proper install with all the paths set up correctly
Using gcc on windows and clang on mac
|
@yuxiaomao Could you check/merge this? |
|
Seems good for me. However, @tobil4sk also showed me when optimization flags (-O3) are enabled - some tests are failing similar to the msvc case, we might needs to address that too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables hlc tests on windows with gcc and mac with clang.
It would still be a good idea to compile on windows with msvc, but the unit tests aren't passing yet, that is being handled in: #11733.