return Result<T, E> from IO functions #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because of the original form of this if-statement, threads that were in WORK mode and that had a high-priority redex but no low priority redexes would not do any work. this led to a bug where `save_redexes` was called while high-priority redexes were still present.
returns Result<T,E> for appropriate io functions, matches up with C implementation
developedby
requested changes
Aug 1, 2024
Since some IO errors are shared across IO functions (invalid argument type, unexpected IO function name), we add a custom IOError ADT. Now, every IO function (even those that cannot fail) will return a Result<T, IOError<E>>. When attempting to invoke an IO function with an invalid name, an IOError/Name is returned.
Add io programs that test basic functionality, including failures. This also updates the "smoke test" file, that does a sequence of open, read, write, close io calls on a file.
basic.bend couldn't be run in CUDA as the main definition was too large
otherwise the rust impl will run on these
they were stale, and didn't represent the shortest bend code that can invoke io functions
developedby
requested changes
Aug 5, 2024
the README is more likely to change and break tests than the LICENSE file.
the Str struct was stale in the header files
|
Going to hold off on merging as there is some issue with the C runtime hanging on this code (on an M1 mac only, not on my intel machine) |
amazingly this bug hadn't been caught before. we were not checking the number of arguments in `ctr` before accessing them, therefore accessing meaningless memory regions, which could lead to infinite loops as nothing would be reduced and the same "interaction" would be attempted endlessly.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.