set prefer_loading_from_api: true for brew fetch

[steveh7812]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

This is to fix #13088 by passing prefer_loading_from_api: true when calling to_formulae_and_casks. I am following what I found in Library/Homebrew/cmd/install.rb and this solves the issue in my testing; however I know there are larger discussions happening around overall support for HOMEBREW_INSTALL_FROM_API so I'm happy to incorporate any additional changes that are needed.

[Rylan12]

Thanks for the PR! This is a good start (it's what I would have done). In testing, it looks like brew fetch --deps doesn't work quite right for formulae. I'll continue looking into it to figure out what the best fix for it is.

[Bo98]

I'm fine with merging even a partial fix given the situation could change under #12936.

[Rylan12]

I'd rather not merge a known bug given that the other PR is still in draft form.

I poked around more and found that the problem is that brew fetch --deps fetches all dependencies and HOMEBREW_INSTALL_FROM_API only knows how to handle runtime dependencies. We avoid this when running brew install by only fetching runtime dependencies. I pushed a commit that modifies the way that brew fetch --deps works so that when HOMEBREW_INSTALL_FROM_API is set, it will only return runtime dependencies (I think this is fine since building from source with HOMEBREW_INSTALL_FROM_API isn't supported). All other cases are unchanged.

[Bo98]

I'd rather not merge a known bug

My point was that it was pre-existing but yes.

I poked around more and found that the problem is that brew fetch --deps fetches all dependencies and HOMEBREW_INSTALL_FROM_API only knows how to handle runtime dependencies. We avoid this when running brew install by only fetching runtime dependencies. I pushed a commit that modifies the way that brew fetch --deps works so that when HOMEBREW_INSTALL_FROM_API is set, it will only return runtime dependencies (I think this is fine since building from source with HOMEBREW_INSTALL_FROM_API isn't supported). All other cases are unchanged.

Does this overlap with #13065 at all?

[MikeMcQuaid]

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @steveh7812!

[steveh7812]

Thanks @MikeMcQuaid !