Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: drop libz-dev #16702

Merged
merged 1 commit into from
May 17, 2024
Merged

Dockerfile: drop libz-dev #16702

merged 1 commit into from
May 17, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Feb 19, 2024

This causes formulae to build against with system zlib which we don't want.

The original need for it is also no longer valid: 5e42f67

@Bo98 Bo98 enabled auto-merge February 19, 2024 18:42
@Bo98 Bo98 disabled auto-merge February 19, 2024 18:46
@Bo98
Copy link
Member Author

Bo98 commented Feb 19, 2024

Looks like Portable Ruby has a -lz in its rbconfig which I'll need to fix first.

@p-linnane
Copy link
Member

@Bo98 Do we need a new Portable Ruby release?

@Bo98
Copy link
Member Author

Bo98 commented Feb 20, 2024

Yes.

Might be a good opportunity try the Bootsnap thing I've talked about a couple times, and to update the cross-build CI images since we need to do that and I said I would this month.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks again @Bo98!

@Bo98 Bo98 added the in progress Maintainers are working on this label Mar 11, 2024
@p-linnane p-linnane merged commit 79cb329 into Homebrew:master May 17, 2024
29 checks passed
@Bo98 Bo98 deleted the no-zlib-dev branch May 17, 2024 11:44
@Bo98 Bo98 removed the in progress Maintainers are working on this label May 17, 2024
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants