Restrict direct url installs to the file://
scheme
#17697
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?We already don't allow installing or loading formulae directly from a URL (e.g.
brew install https://example.com/foo.tar.gz
), so this PR extends that to casks and also strengthens the check to ensure that thefile://
URL scheme is the only one allowed byFromURILoader
.Additionally, this PR does not allow loading formulae directly form a bottle URL (except for a
file://
URL).I've opted to still have this return an error message like is currently done, but we also could put a deprecation there and eventually just have
Formulary.loader_for("https://...")
go right toNullLoader
.