sbom: ensure Homebrew versions are more consistent. #17876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid making bottles non-reproducible by ensuring that the Homebrew version doesn't include the full commit hash but just a `-dev` suffix. This is similar to the approach we use for analytics.
woodruffw
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Makes sense to me! This arguably makes the SBOM slightly less precise but I think that precision isn't necessarily desirable here anyways.
(The alternative would be to have things like dispatch-rebottle "freeze" the master ref it's working on to ensure reproducibility.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid making bottles non-reproducible by ensuring that the Homebrew
version doesn't include the full commit hash but just a
-devsuffix.This is similar to the approach we use for analytics.