Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump more files to Sorbet typed: strict #18354

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Bump more files to Sorbet typed: strict #18354

merged 2 commits into from
Oct 6, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Sep 18, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @issyl0! A few style suggestions, none blocking.

Library/Homebrew/cask/migrator.rb Outdated Show resolved Hide resolved
Library/Homebrew/help.rb Outdated Show resolved Hide resolved
Library/Homebrew/help.rb Outdated Show resolved Hide resolved
Library/Homebrew/help.rb Outdated Show resolved Hide resolved
Library/Homebrew/help.rb Outdated Show resolved Hide resolved
Library/Homebrew/help.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_cellar_checks.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_cellar_checks.rb Outdated Show resolved Hide resolved
Library/Homebrew/help.rb Outdated Show resolved Hide resolved
@issyl0
Copy link
Member Author

issyl0 commented Oct 2, 2024

Sorry for the delay here, I thought the style issues were the only ones. But I'll get around to fixing the actual typechecking failures hopefully tonight!

@issyl0 issyl0 force-pushed the back-to-srb branch 2 times, most recently from 5549714 to 9975249 Compare October 6, 2024 18:19
@issyl0 issyl0 merged commit a917ce2 into master Oct 6, 2024
27 checks passed
@issyl0 issyl0 deleted the back-to-srb branch October 6, 2024 20:01
@issyl0
Copy link
Member Author

issyl0 commented Oct 6, 2024

Sorry, I forgot this still had auto-merge on. Oh well, if it 💥 and I can't fix it ahead of tomorrow's release, then revert?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants