Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula: fix alias/generic/prepend std_cmake_args issue. #18364

Merged
merged 1 commit into from
Sep 20, 2024
Merged

formula: fix alias/generic/prepend std_cmake_args issue. #18364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Library/Homebrew/extend/os/mac/formula.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
).returns(T::Array[String])
}
def std_cmake_args(install_prefix: prefix, install_libdir: "lib", find_framework: "LAST")
args = generic_std_cmake_args(install_prefix:, install_libdir:, find_framework:)
args = super

Check warning on line 24 in Library/Homebrew/extend/os/mac/formula.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/extend/os/mac/formula.rb#L24 

Added line #L24 was not covered by tests

# Avoid false positives for clock_gettime support on 10.11.
# CMake cache entries for other weak symbols may be added here as needed.
Expand Down
1 change: 0 additions & 1 deletion Library/Homebrew/formula.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1822,7 +1822,6 @@ def std_cmake_args(install_prefix: prefix, install_libdir: "lib", find_framework
-DBUILD_TESTING=OFF
]
end
alias generic_std_cmake_args std_cmake_args

# Standard parameters for configure builds.
sig {
Expand Down
Loading