Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump rubocop-ast from 1.33.0 to 1.34.0 in /Library/Homebrew #18707

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 4, 2024

Bumps rubocop-ast from 1.33.0 to 1.34.0.

Changelog

Sourced from rubocop-ast's changelog.

1.34.0 (2024-11-04)

New features

1.33.1 (2024-11-02)

Bug fixes

  • #325: Allow non_bare_access_modifier_declaration? to handle modifiers with multiple arguments. ([@​dvandersluis][])
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop-ast](https://github.com/rubocop/rubocop-ast) from 1.33.0 to 1.34.0.
- [Release notes](https://github.com/rubocop/rubocop-ast/releases)
- [Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-ast@v1.33.0...v1.34.0)

---
updated-dependencies:
- dependency-name: rubocop-ast
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Bumping Gemfile dependencies ruby Pull requests that update Ruby code labels Nov 4, 2024
@dduugg
Copy link
Member

dduugg commented Nov 4, 2024

The rubocop failure is an odd one, since this a rubocop-ast upgrade: https://github.com/Homebrew/brew/actions/runs/11668639721/job/32488766027?pr=18707#step:7:16

livecheck.rb:180:3: C: [Correctable] Style/AccessModifierDeclarations: private should not be inlined in method definitions.
  private :version, :arch
  ^^^^^^^

It also shouldn't be a violation, looking at the cop's rdoc: https://github.com/rubocop/rubocop/blob/95b56384f7cdedf6eea8062a9b36d570b95850c6/lib/rubocop/cop/style/access_modifier_declarations.rb#L70

🤔

@Bo98
Copy link
Member

Bo98 commented Nov 4, 2024

Probably needs rubocop/rubocop#13404. Can try this again when 1.68.1 or later is out.

@samford samford removed their request for review November 6, 2024 14:35
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 7, 2024

A newer version of rubocop-ast exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@p-linnane
Copy link
Member

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 7, 2024

Superseded by #18732.

@dependabot dependabot bot closed this Nov 7, 2024
@dependabot dependabot bot deleted the dependabot/bundler/Library/Homebrew/rubocop-ast-1.34.0 branch November 7, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Bumping Gemfile dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants