Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Simple Comic to a community maintained fork #96619

Closed
wants to merge 3 commits into from
Closed

Update Simple Comic to a community maintained fork #96619

wants to merge 3 commits into from

Conversation

boggydigital
Copy link
Contributor

@boggydigital boggydigital commented Dec 22, 2020

Simple Comic homepage (http://dancingtortoise.com/simplecomic/) used to link to https://github.com/arauchfuss/Simple-Comic. However the last commit happened in Apr 2017 and after a discussion community has created a new modern maintained fork: https://github.com/MaddTheSane/Simple-Comic

Here is the issue where the discussion happened with more details: arauchfuss/Simple-Comic#126

In this PR, I'm intentionally redirecting download and other links to this new community maintained fork. Let me know if there is other information that would help here.

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask {{cask_file}} worked successfully.
  • brew install --cask {{cask_file}} worked successfully.
  • brew uninstall --cask {{cask_file}} worked successfully.

Simple Comic homepage (http://dancingtortoise.com/simplecomic/) used to link to https://github.com/arauchfuss/Simple-Comic. However the last commit happened in Apr 2017 and after a discussion community has created a new modern maintained fork: https://github.com/MaddTheSane/Simple-Comic

Here is the issue where the discussion happened with more details: arauchfuss/Simple-Comic#126

In this PR, I'm intentionally redirecting download and other links to this new community maintained fork. Let me know if there is other information that would help here.
New community fork doesn't have a dedicated website, and verified only applies when download is different from homepage
name "Simple Comic"
desc "Comic viewer/reader"
homepage "https://dancingtortoise.github.io/"
desc "Streamlined comic viewer"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Streamlined” is marketing fluff and does not belong in descriptions.

@vitorgalvao
Copy link
Member

vitorgalvao commented Dec 24, 2020

The documentation and precedents we have are clear. Unless the main repo points to this specific fork as the official continuation (doesn’t seem to be the case) or the fork is so popular it dwarfs the original and becomes the new default (also not the case), this can’t overtake the main cask. We’ll not switch it to some random fork users may not want.

The documentation is also clear that there is a path for this to be accepted, however. Make a new cask named maddthesane-simple-comic and it can be accepted.

@boggydigital boggydigital deleted the patch-2 branch December 24, 2020 22:09
@boggydigital
Copy link
Contributor Author

@vitorgalvao, that's fair. I'll open a new cask - thanks for identifying the path forward!

@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants