Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: use set -xeuo pipefail globally #192234

Merged
merged 1 commit into from
Sep 30, 2024
Merged

workflows: use set -xeuo pipefail globally #192234

merged 1 commit into from
Sep 30, 2024
+77 −27

Conversation

carlocab
Copy link
Member

This is the same change as Homebrew/brew#18369.

@carlocab carlocab requested review from a team and MikeMcQuaid as code owners September 28, 2024 20:29
@carlocab carlocab added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Sep 28, 2024
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Sep 28, 2024
MikeMcQuaid
MikeMcQuaid approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carlocab!

@carlocab carlocab added this pull request to the merge queue Sep 30, 2024
Merged via the queue into master with commit be09ad3 Sep 30, 2024
29 checks passed
@carlocab carlocab deleted the stricter-shell branch September 30, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rylan12 Rylan12 Rylan12 approved these changes

@woodruffw woodruffw woodruffw approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

@bayandin bayandin bayandin approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. workflows PR modifies GitHub Actions workflow files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@carlocab @MikeMcQuaid @bayandin @chenrui333 @woodruffw @Rylan12