formulae_dependents: ignore more unbottled errors #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't fail CI if we fail to install an unbottled dependent, even when we're not building from source. Fixes failures seen at https://github.com/Homebrew/homebrew-core/actions/runs/10956242397/job/30553837181?pr=189352
|
Error seen at Homebrew/homebrew-core#189352 |
Why not? How will we know if we break the dependent if we're not able to fetch it to test? |
Not sure I follow -- we'll know if we break the dependent if it fails on runners where it is bottled. And if the dependent was unbottled in the first place, it likely was already broken. |
|
Ok, rereading this again: I think I misunderstood the first time. Makes sense, thanks for explaining! |
MikeMcQuaid
approved these changes
Sep 24, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't fail CI if we fail to install an unbottled dependent, even
when we're not building from source.
Fixes failures seen at https://github.com/Homebrew/homebrew-core/actions/runs/10956242397/job/30553837181?pr=189352