ICD: Promote read replicas

[lornakelly]

• Allow promotion of read replicas for postgresql, mysql and enterprisedb instances

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes https://github.ibm.com/compose/App/issues/1352

Output from acceptance testing:

=== RUN   TestAccIBMDatabaseInstancePostgresReadReplicaPromotion
=== PAUSE TestAccIBMDatabaseInstancePostgresReadReplicaPromotion
=== CONT  TestAccIBMDatabaseInstancePostgresReadReplicaPromotion
--- PASS: TestAccIBMDatabaseInstancePostgresReadReplicaPromotion (1174.03s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database        1177.472s

=== RUN   TestAccIBMDatabaseInstanceMySQLReadReplicaPromotion
=== PAUSE TestAccIBMDatabaseInstanceMySQLReadReplicaPromotion
=== CONT  TestAccIBMDatabaseInstanceMySQLReadReplicaPromotion
--- PASS: TestAccIBMDatabaseInstanceMySQLReadReplicaPromotion (498.19s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database        501.844s

=== RUN   TestAccIBMDatabaseInstanceEDBReadReplicaPromotion
=== PAUSE TestAccIBMDatabaseInstanceEDBReadReplicaPromotion
=== CONT  TestAccIBMDatabaseInstanceEDBReadReplicaPromotion
--- PASS: TestAccIBMDatabaseInstanceEDBReadReplicaPromotion (1993.78s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database        1996.886s

...

[alexhemard]

Rather than duplicating the minimal configuration, you can compose the two configs,
testAccCheckIBMDatabaseInstanceMySQLMinimal and testAccCheckIBMDatabaseInstanceMySQLMinimal_ReadReplica

See MongDB Enterprise https://github.com/IBM-Cloud/terraform-provider-ibm/blob/master/ibm/service/database/resource_ibm_database_mongodb_enterprise_test.go#L160-L162

[lornakelly]

@alexhemard have been working on this for a while and cant seem to find out why combining the above is breaking the tests. These are the changes but just looks at the resource_ibm_database_postgresql_test.go test file as that is what I am trying to get working first
0ab9de7

From what I can tell, the destroy function seems to get executed before the promote step (step 2) so the promote never happens and then we get an expected error that you cant delete leader that has replica. I have read up and that the destroy function should execute after the final step but that doesnt seem to be the case - any ideas?

FYI In the mongo example, there is no step after the combined one

[lornakelly]

@alexhemard Pushed updates to tests based on convo yesterday. One change is the sourceInstanceCRN doesnt actually get set in the test func - so cant pass it as a param in read replica step so I did the same as the mongo which is reference it directly.

I think an enhancement to the Exists function is to return the crn as well so we can use it but probably out of scope for this ticket. Let me know if you want me to change it

[alexhemard]

LGTM