Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fixes for scikit-learn v1.4 #91

Merged
merged 6 commits into from
Jan 23, 2024
Merged

[BUG] Fixes for scikit-learn v1.4 #91

merged 6 commits into from
Jan 23, 2024

Conversation

naoise-h
Copy link
Member

This PR provides a number of bugfixes for the newly-released Scikit-learn v1.4. Explicit support for Python 3.12 is also added.

  • Minor changes to DecisionTreeClassifier and _logistic_regression_path

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0e6cea9) 99.16% compared to head (3d9f1cf) 99.09%.

Files Patch % Lines
diffprivlib/models/forest.py 80.00% 1 Missing ⚠️
diffprivlib/models/logistic_regression.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   99.16%   99.09%   -0.08%     
==========================================
  Files          34       34              
  Lines        2645     2653       +8     
==========================================
+ Hits         2623     2629       +6     
- Misses         22       24       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naoise-h naoise-h merged commit 9dde5b9 into main Jan 23, 2024
38 of 40 checks passed
@naoise-h naoise-h deleted the sklearn-1.4 branch February 28, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant