Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formapi): Ajout d'un message notifiant qu'il n'y a aucune donnée… #65

Open
wants to merge 2 commits into
base: Api_telechargement
Choose a base branch
from

Conversation

Naminoshin
Copy link
Collaborator

Description

Fait en sorte d'afficher un message indiquant qu'il n'y a pas de donnée pour les filtres sélectionnés #49

Architectural changes

The following library now depends on [...]

Screenshots

[...]

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by Organization ABC.

Copy link

github-actions bot commented Nov 6, 2024

Affected libs: api-metadata-converter, feature-editor, api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-auth, ui-search, common-domain, common-fixtures, ui-elements, feature-notifications, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz, database-dump, data-access-datafeeder, util-data-fetcher, util-app-config, data-access-gn4, util-i18n,
Affected apps: datahub, metadata-converter, metadata-editor, datafeeder, demo, webcomponents, search, map-viewer, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link

github-actions bot commented Nov 6, 2024

📷 Screenshots are here!

class="text-center"
*ngIf="(listFilteredProduct$ | async)?.length === 0"
>
Aucune donnée pour les filtres sélectionnés

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faudrait utiliser le fichier de traduction et au moins le traduire en anglais

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants