Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed webserver API endpoints #6751

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 18, 2024

What do these changes do?

Endpoints for creating a node and creating a new project did had some optional parameters that were not respected.

After the Pydantic v2 migration, these became mandatory, which was wrong. Aligned with what the OpenAPI spec (and the frontend) require.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Nov 18, 2024
@GitHK GitHK added the t:maintenance Some planned maintenance work label Nov 18, 2024
@GitHK GitHK added this to the Event Horizon milestone Nov 18, 2024
@GitHK GitHK changed the title fixed API endpoints 🐛 Fixed webserver API endpoints Nov 18, 2024
Copy link

sonarcloud bot commented Nov 18, 2024

@GitHK GitHK marked this pull request as ready for review November 18, 2024 14:54
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.19%. Comparing base (fa57c9e) to head (eda7112).
Report is 2 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6751      +/-   ##
===============================================================================
+ Coverage                                        84.11%   88.19%   +4.08%     
===============================================================================
  Files                                             1530     1184     -346     
  Lines                                            65522    50243   -15279     
  Branches                                          2226      933    -1293     
===============================================================================
- Hits                                             55114    44312   -10802     
+ Misses                                           10072     5796    -4276     
+ Partials                                           336      135     -201     
Flag Coverage Δ
integrationtests 64.72% <ø> (+11.41%) ⬆️
unittests 85.62% <100.00%> (+0.34%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.18% <100.00%> (ø)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.37% <ø> (+7.16%) ⬆️
agent 97.01% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 58.38% <ø> (ø)
director_v2 90.81% <ø> (+2.26%) ⬆️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.76% <ø> (+1.53%) ⬆️
efs_guardian 90.12% <ø> (ø)
invitations 93.49% <ø> (ø)
osparc_gateway_server 85.49% <ø> (-0.26%) ⬇️
payments 92.77% <ø> (ø)
resource_usage_tracker 90.79% <ø> (ø)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.67% <ø> (+8.33%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa57c9e...eda7112. Read the comment docs.

---- 🚨 Try these New Features:

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@GitHK GitHK merged commit 75f06e4 into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 19, 2024
84 of 90 checks passed
@GitHK GitHK deleted the fixed-api-endpoints branch November 19, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants