-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixed webserver API endpoints #6751
🐛 Fixed webserver API endpoints #6751
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pydantic_v2_migration_do_not_squash_updates #6751 +/- ##
===============================================================================
+ Coverage 84.11% 88.19% +4.08%
===============================================================================
Files 1530 1184 -346
Lines 65522 50243 -15279
Branches 2226 933 -1293
===============================================================================
- Hits 55114 44312 -10802
+ Misses 10072 5796 -4276
+ Partials 336 135 -201
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
packages/models-library/src/models_library/api_schemas_webserver/projects.py
Show resolved
Hide resolved
75f06e4
into
ITISFoundation:pydantic_v2_migration_do_not_squash_updates
What do these changes do?
Endpoints for creating a node and creating a new project did had some optional parameters that were not respected.
After the Pydantic v2 migration, these became mandatory, which was wrong. Aligned with what the OpenAPI spec (and the frontend) require.
Related issue/s
How to test
Dev-ops checklist