-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ OpenTelemetry Enhancements: Filter out healthchecks, add catalog internals instrumentation #6752
♻️ OpenTelemetry Enhancements: Filter out healthchecks, add catalog internals instrumentation #6752
Conversation
Co-authored-by: Andrei Neagu <neagu@itis.swiss>
…ISFoundation#6395) Co-authored-by: Dustin Kaiser <mail@dustinkaiser.eu>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pedro Crespo-Valero <32402063+pcrespov@users.noreply.github.com>
Co-authored-by: Andrei Neagu <neagu@itis.swiss>
ITISFoundation#5892) Co-authored-by: Andrei Neagu <neagu@itis.swiss>
…the node is a frontend node (ITISFoundation#6434) Co-authored-by: Dustin Kaiser <8209087+mrnicegyu11@users.noreply.github.com>
Co-authored-by: Andrei Neagu <neagu@itis.swiss>
Co-authored-by: Andrei Neagu <neagu@itis.swiss>
Co-authored-by: Andrei Neagu <neagu@itis.swiss>
services/catalog/src/simcore_service_catalog/api/rest/_services.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6752 +/- ##
===========================================
- Coverage 88.50% 66.05% -22.45%
===========================================
Files 1549 662 -887
Lines 62410 32610 -29800
Branches 2125 265 -1860
===========================================
- Hits 55238 21542 -33696
- Misses 6844 11007 +4163
+ Partials 328 61 -267
Continue to review full report in Codecov by Sentry.
|
services/catalog/src/simcore_service_catalog/api/rest/_services.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
services/catalog/src/simcore_service_catalog/api/rest/_services.py
Outdated
Show resolved
Hide resolved
services/catalog/src/simcore_service_catalog/api/rest/_services.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the effort. Just a few suggestions from my side.
services/catalog/src/simcore_service_catalog/api/rest/_services.py
Outdated
Show resolved
Hide resolved
As agreed with @bisgaard-itis we don't add manual telemetry instrumentation for now,he will try to push a magic decorator in the servicelib that we can use to do this :--) Much cleaner, less noisy! |
Quality Gate passedIssues Measures |
What do these changes do?
list_services
call of the catalog.How to test
By modifying the
.env-devel
file locally as such:opentelemetry can be disabled and one can verify that simcore still works without issues. Calls to the
_tracer
are interpreted as a no-op automatically.Dev-ops checklist