Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ improving e2e tests (socketio reconnect) #6759

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Nov 19, 2024

What do these changes do?

  • ♻️ In the e2e tests, in various places (log in/out, service start, ...) we expect certain socketio events to be received. If the socket.io connection is lost, the test fails. This PR introduces a mechanism for the e2e test to attempt reconnection and continue listening for events, similar to how the frontend behaves.

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 changed the title ♻️ improving e2e tests (socketio reconnect, CI tests) ♻️ improving e2e tests (socketio reconnect) Nov 19, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review November 19, 2024 10:15
@matusdrobuliak66 matusdrobuliak66 self-assigned this Nov 19, 2024
@matusdrobuliak66 matusdrobuliak66 added the e2e Bugs found by or related to the end-2-end testing label Nov 19, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Nov 19, 2024
@matusdrobuliak66 matusdrobuliak66 added the t:maintenance Some planned maintenance work label Nov 19, 2024
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! thanks!

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (063677b) to head (c556f92).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6759      +/-   ##
==========================================
+ Coverage   88.17%   88.54%   +0.36%     
==========================================
  Files        1549     1542       -7     
  Lines       62410    62209     -201     
  Branches     2125     2125              
==========================================
+ Hits        55030    55082      +52     
+ Misses       7054     6799     -255     
- Partials      326      328       +2     
Flag Coverage Δ
integrationtests 64.85% <ø> (+11.28%) ⬆️
unittests 86.48% <ø> (+0.03%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.38% <ø> (ø)
pkg_dask_task_models_library 96.87% <ø> (ø)
pkg_models_library 91.93% <ø> (ø)
pkg_notifications_library 83.79% <ø> (ø)
pkg_postgres_database 87.33% <ø> (ø)
pkg_service_integration 71.44% <ø> (ø)
pkg_service_library 76.50% <ø> (-0.07%) ⬇️
pkg_settings_library 91.42% <ø> (ø)
pkg_simcore_sdk 85.27% <ø> (ø)
agent 96.98% <ø> (ø)
api_server 89.88% <ø> (ø)
autoscaling 95.22% <ø> (ø)
catalog 89.42% <ø> (ø)
clusters_keeper 98.72% <ø> (ø)
dask_sidecar 91.32% <ø> (ø)
datcore_adapter 94.05% <ø> (ø)
director 76.09% <ø> (+0.08%) ⬆️
director_v2 90.92% <ø> (-0.02%) ⬇️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.78% <ø> (ø)
efs_guardian 90.01% <ø> (ø)
invitations 93.51% <ø> (ø)
osparc_gateway_server 85.15% <ø> (ø)
payments 92.87% <ø> (ø)
resource_usage_tracker 90.80% <ø> (ø)
storage 89.76% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.75% <ø> (+1.16%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 063677b...c556f92. Read the comment docs.

---- 🚨 Try these New Features:

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) November 19, 2024 12:04
Copy link

sonarcloud bot commented Nov 19, 2024

@matusdrobuliak66 matusdrobuliak66 merged commit 5cf0635 into ITISFoundation:master Nov 19, 2024
87 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants