-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses typing_extensions.TypedDict in all instances used in pydantic models AND fixes with migration of rest_ordering #6770
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pydantic_v2_migration_do_not_squash_updates #6770 +/- ##
===============================================================================
- Coverage 86.97% 85.44% -1.54%
===============================================================================
Files 1364 1480 +116
Lines 54887 59876 +4989
Branches 1296 1833 +537
===============================================================================
+ Hits 47740 51162 +3422
- Misses 6955 8410 +1455
- Partials 192 304 +112
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Quality Gate passedIssues Measures |
0aea337
into
ITISFoundation:pydantic_v2_migration_do_not_squash_updates
What do these changes do?
All
TypedDict
used in pydantic models forpython <3.12
should use the backport librarytyping_extensions
SEE https://docs.pydantic.dev/latest/api/standard_library_types/#typeddict
NOTE that we should not always import from the backport library
typing_extensions
but only thoseTypedDict
used inside models.rest_ordering.py
in https://github.com/ITISFoundation/osparc-simcore/pull/6763/filesRelated issue/s
How to test
Dev-ops checklist