Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minors changes for JOSS paper #76

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Minors changes for JOSS paper #76

merged 5 commits into from
Mar 6, 2024

Conversation

JanJereczek
Copy link
Contributor

This PR includes following minor changes:

  • My second affiliation has been removed
  • /paper has been excluded from codecov, which should largely address Increase test coverage to at least 85% #64
  • The abstracts have been removed from paper.bib
  • The url link for the documentation in paper.md has been fixed

@Datseris
Copy link
Member

it is a waste of computational resources to constantly build the PDF of the paper in every single PR. Let's please remove the draft-pdf workflow once you have managed to build the paper once.

@JanJereczek
Copy link
Contributor Author

Yes, I think we already agreed on removing the pdf build action as soon as the paper is published!

@JanJereczek
Copy link
Contributor Author

Documentation is not built properly because of a change in the interplay between trajectory and obtain_state in DynamicalSystemsBase.jl (used in logisitc example of the docs).

@Datseris
Copy link
Member

Fixed in JuliaDynamics/DynamicalSystemsBase.jl#201

@JanJereczek , some advice for the future. If you have found an error, paste it. Don't just say "this error happened", copy the error message and paste it. Or alternatively copy the CI log line that has the error if you don't want to paste the entire thing. Let's not duplicate the effort to find the bug, which in some cases like now is trivial, but in general is non zero.

@JanJereczek
Copy link
Contributor Author

Thanks for fixing it @Datseris. The PR should be ready to merge! You are right, I will include the error messages in future :)

@Datseris Datseris merged commit 80db37a into main Mar 6, 2024
3 checks passed
@Datseris Datseris deleted the minors-paper branch March 6, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants