Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unary and number broadcast; add all #83

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

putianyi889
Copy link
Contributor

also added methods for similar and a minor fix

@coveralls
Copy link

coveralls commented Mar 26, 2023

Pull Request Test Coverage Report for Build 4536645934

  • 28 of 32 (87.5%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 94.465%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ToeplitzMatrices.jl 0 1 0.0%
src/hankel.jl 5 6 83.33%
src/special.jl 6 8 75.0%
Files with Coverage Reduction New Missed Lines %
src/hankel.jl 1 95.06%
Totals Coverage Status
Change from base Build 4484183626: -0.1%
Covered Lines: 751
Relevant Lines: 795

💛 - Coveralls

@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (3d47002) 95.25% compared to head (4ed4ab0) 94.60%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/special.jl 50.00% 4 Missing ⚠️
src/ToeplitzMatrices.jl 0.00% 2 Missing ⚠️
src/hankel.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   95.25%   94.60%   -0.65%     
==========================================
  Files           9        9              
  Lines         948      964      +16     
==========================================
+ Hits          903      912       +9     
- Misses         45       52       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@putianyi889 putianyi889 changed the title add unary and number broadcast; add _all add unary and number broadcast; add all Mar 27, 2023
@putianyi889 putianyi889 marked this pull request as draft March 28, 2023 12:07
@putianyi889
Copy link
Contributor Author

should make mapreduce instead of all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants