Fix sentiment scaling issue with "but" conjunction #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the sentiment scaling function that occurs when the conjunction "but" is present in the text. The bug causes incorrect scaling of sentiment values before and after the "but" conjunction. The fix ensures that the sentiment values are correctly scaled based on the position of the "but" conjunction. This improves the accuracy of sentiment analysis in texts containing contrasting statements.
The pull request also includes a makefile that provides convenient commands for installation, linting, testing, and static type checking. The makefile allows developers to easily set up the project environment and perform common development tasks.
fixes #169