-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text icons for HQ items and collectables #77
Conversation
This makes the search more "correct" and consistent to the recipe search. Additionally the search for all HQ items of a category is now possible.
…cively in the search text This allows for easy input of those special characters without pasting them directly.
I made the requested change and (hopefully) fixed the failing tests. One of the tests ( Additionally, I implemented two of my proposed alterations that I would now consider a usability improvement:
Without these changes a user can not easily search for the same things possible in the current version of Raphael. Specifically, searches that included "(HQ)" at the end were not possible. |
Nice work! Thank you for your contribution :) |
Adds text icons for HQ items and collectables using the same Unicode characters Final Fantasy XIV uses.
Additionally, improves the handling of pasted text copied from the game and changes
game_data::Item
to useAlwaysCollectable
instead ofIsCollectable
fromItem.csv
.Overview of the changes:
'\u{e03c}'
instead of "(HQ)" when displaying the name of HQ items'\u{e03d}'
to the end of the name of collectablesgame_data::Item
to useAlwaysCollectable
instead ofIsCollectable
fromItem.csv
.Caveats / Limitations caused by the current implementation:
Item.csv
which is potentially undesirable. Alternatively, you could pass an additional argument (can_be_collectable
) togame_data::get_item_name
Screenshot: