Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds description search to projects/repositories #676

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Adds description search to projects/repositories #676

merged 1 commit into from
Mar 29, 2024

Conversation

dpfens
Copy link
Contributor

@dpfens dpfens commented Mar 29, 2024

To close #651, search project/repository descriptions for query matches.

@dpfens dpfens requested a review from a team as a code owner March 29, 2024 16:09
var query = $scope.query.toLowerCase(),
name = value.name.toLowerCase(),
description = value.description ? value.description.toLowerCase() : '';
queryMatch = name.indexOf(query) > -1 || description.indexOf(query) > -1;
Copy link
Contributor Author

@dpfens dpfens Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only logic change. Other changes are white-space changes to have consistent formatting provided by js-beautify

@hauten
Copy link
Contributor

hauten commented Mar 29, 2024

Works great locally

@hauten hauten merged commit 4128edb into LLNL:main Mar 29, 2024
1 check passed
@dpfens dpfens deleted the query_description branch March 29, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can catalog search include repo descriptions?
2 participants