ale3d #248
ale3d #248
Conversation
numbers as the fragment IDs. Using fragment IDs in evaluateDerivatives to turn off forces between fragments when they are moving away from each other.
This happens in FEusion/SPH when we update the smoothing lengths with the scaling factor.
…ABLE_STATIC_TPL. Even with ENABLE_STATIC_TPL=OFF, the default build sets polytope and silo extensions to .a, so we set it to .dylib on MacOSX here.
…tsuji1/spheral
…itlab/CI stuff again, since the tests seem to be failing inconsistently.
There was a problem hiding this comment.
One last change on the CMake flag, after that I'm good with all the changes I can approve. We do need @jmikeowen to review this as well before merge.
|
@mdavis36 I believe I made the changes you requested for the CMake stuff, but I'm not sure how to change the status of that request (it still appears as "1 change requested" in the review). Can you resolve or update? |
There was a problem hiding this comment.
I'm happy with CS related changes, but we still want @jmikeowen to look over this and approve before merging.
those for our specific case in ALE3D and we can construct it in our interface.
…/ale/rzspheral into ale3d
…they exist on the rzspheral gitlab repo.
|
@jmikeowen I've reverted the changes to make the "mask" variable automatically registered in the state. I've also changed some of the logic in computeFragmentField to look like computeVoronoiVolume, let me know if that looks good. |
Summary