Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy .sh files for .dsv hooks (backport #8) #10

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 8, 2024

When building packages with ament_package .dsv files are not taken in properly unless there is a .sh file with the same name registered with ament_environment_hooks. This is not the case when building the package with colcon. This PR adds dummy .sh file so the the hooks work as expected under all circumstances.


This is an automatic backport of pull request #8 done by Mergify.

* Add dummy .sh files for .dsv hooks

* Add back .in extension to worlds hook

(cherry picked from commit 4b66204)
Copy link
Author

mergify bot commented Nov 8, 2024

⚠️ The sha of the head commit of this PR conflicts with #9. Mergify cannot evaluate rules on this PR. ⚠️

@bjsowa bjsowa closed this Nov 8, 2024
@bjsowa bjsowa deleted the mergify/bp/humble/pr-8 branch November 8, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants