Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update generator status default values to snapshot height #202

Conversation

nagdahimanshu
Copy link
Contributor

@nagdahimanshu nagdahimanshu commented Nov 8, 2023

What was the problem?

This PR resolves #201

How was it solved?

  • Update generator status default values to snapshot height when forging is false

How was it tested?

  • Locally against mainnet

@nagdahimanshu nagdahimanshu self-assigned this Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #202 (815d488) into release/2.0.0 (1df436e) will increase coverage by 0.06%.
The diff coverage is 60.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/2.0.0     #202      +/-   ##
=================================================
+ Coverage          82.08%   82.15%   +0.06%     
=================================================
  Files                 25       25              
  Lines                815      818       +3     
  Branches             117      120       +3     
=================================================
+ Hits                 669      672       +3     
  Misses               146      146              
Files Coverage Δ
src/utils/commands.ts 94.11% <100.00%> (+0.56%) ⬆️
src/utils/node.ts 43.96% <0.00%> (ø)

@nagdahimanshu nagdahimanshu marked this pull request as ready for review November 9, 2023 13:00
Copy link
Contributor

@sameersubudhi sameersubudhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nagdahimanshu nagdahimanshu merged commit 75fee7d into release/2.0.0 Nov 10, 2023
7 of 8 checks passed
@nagdahimanshu nagdahimanshu deleted the 201-update-generator-status-default-values-to-snapshot-height branch November 10, 2023 07:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants