Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add edge-case scenario handling in getLogLevel #209

Merged

Conversation

sameersubudhi
Copy link
Contributor

@sameersubudhi sameersubudhi commented Dec 2, 2023

What was the problem?

This PR resolves #208

How was it solved?

  • Add error handling for missing scenarios
  • Add unit tests
  • Update Lisk Core v4 install command to install v4.0.1 or later
  • Bump version to 2.0.1

How was it tested?

  • yarn test config
  • Retested migrator e2e against the mainnet:
    • ./bin/run -s 23362048 -d ~/mainnet-v3 -c ./custom-config.json --auto-migrate-config --auto-start-lisk-core-v4

@sameersubudhi sameersubudhi self-assigned this Dec 2, 2023
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Merging #209 (c3d7aca) into development (8381088) will decrease coverage by 0.02%.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #209      +/-   ##
===============================================
- Coverage        82.15%   82.13%   -0.02%     
===============================================
  Files               25       25              
  Lines              818      823       +5     
  Branches           120      124       +4     
===============================================
+ Hits               672      676       +4     
- Misses             146      147       +1     
Files Coverage Δ
src/utils/config.ts 98.50% <100.00%> (+0.04%) ⬆️
src/utils/node.ts 43.58% <50.00%> (-0.38%) ⬇️

@sameersubudhi sameersubudhi force-pushed the 208-add-edge-case-scenario-handling-in-getLogLevel branch from 3e89429 to c3d7aca Compare December 2, 2023 08:21
Copy link
Contributor

@nagdahimanshu nagdahimanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sameersubudhi sameersubudhi removed the request for review from ManuGowda December 2, 2023 08:28
@sameersubudhi sameersubudhi merged commit 559716b into development Dec 2, 2023
7 of 8 checks passed
@sameersubudhi sameersubudhi deleted the 208-add-edge-case-scenario-handling-in-getLogLevel branch December 2, 2023 08:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add edge-case scenario handling in getLogLevel
2 participants