Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Flow revisions #232

Merged
merged 8 commits into from
Jul 31, 2023
Merged

Login Flow revisions #232

merged 8 commits into from
Jul 31, 2023

Conversation

LossyDragon
Copy link
Collaborator

@LossyDragon LossyDragon commented May 3, 2023

Description

Just some revisions that I'm tracking to help Kotlin, and mobile development.

Changes so far:
Added exceptions that could be thrown for login flow
Added examples in Kotlin for standard and QR login flows
Fixed: pollingWaitForResult() can be cancelled in Kotlin (Coroutines). Cancellation is not possible in Java, so a compat method was added for compatibility. For Java it will just block until the async job fails it.
Fixed interface package name for handing Service Methods.

Checklist

  • Code compiles correctly
  • All tests passing
  • Samples run successfully
  • Extended the README / documentation, if necessary

@LossyDragon LossyDragon changed the title Rev Login Flow revisions May 3, 2023
@LossyDragon
Copy link
Collaborator Author

So far I haven't encountered any major issues with this PR, after some time.

Some minor issues I'd like to correct before merging this revision:

  • Kotlin 1.9.0 / Gradle 8.2.1 are stable as of this post
  • kotlinOptions deprecated in gradle files
  • Signing in with a SteamGuard account in an android app won't show it's session info in the offical steam app. But the samples work fine(?!). (The "Steam App" session show's the same error, but I would expect that since it's contains your SG stuff, so you don't lock yourself out)

@LossyDragon LossyDragon merged commit 2eff456 into Longi94:master Jul 31, 2023
1 check passed
@LossyDragon
Copy link
Collaborator Author

Still can't figure out the last bullet point above as it works when using it as a standard JVM app. But its a non blocking issue.

@LossyDragon LossyDragon deleted the rev branch July 31, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant