Remove the need for kotlin stdlib dependency #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using a java-only project. Removed Kotlin samples as they are not needed. Java/KDoc fixes. Code cleanup and hopefully make AuthSession more readable.
Make pollAuthSessionStatus public
|
Used a recent snapshot with this fix in a blank Maven project, and ran through the samples using the bare minimum dependencies for all the samples. I think it's time for 1.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
AuthSessionsource to be more readableFor Java projects, use
pollingWaitForResultCompat()which is aCompletableFuture<AuthPollResult>.Thanks @SeeMemes and @Eiim for pointing out this goof! See: #257
Checklist