Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace WebSocket connection handler #288

Merged
merged 11 commits into from
Oct 16, 2024
Merged

Conversation

LossyDragon
Copy link
Collaborator

@LossyDragon LossyDragon commented Oct 16, 2024

Description

  • Update connections to differentiate whether a disconnection was userInitiated or not
  • Remove Java-WebSocket in favor of OkHttp Websocket. (Read below)
  • Remove useless ServerMap list in CMClient
  • Update SampleLogonAuthentication
  • Create a connection type based on the next server canidate in the list.
  • Fix null localIp in SteamUser login

Info: Early morning of October 11th, valve accidently broke CM web sockets, and their iOS app. This caused many issues within the 3rd party libraries and apps that use it. The issue seems to be most CM's had some type of TLS configuration error, with most being on TLS 1.3. Now on October 15th, valve seemly fixed this and now checking out WebSocket cm's their certs allow 1.2 and 1.3.

While expirimenting, OKHttp was able to connect to the faulty CM's during that time. And since we use OKHttp for our 'Web' features, this can remove one more dependency for JavaSteam while maintaining the same functionality.

Checklist

  • Code compiles correctly
  • All tests passing
  • Samples run successfully
  • Extended the README / documentation, if necessary

@LossyDragon LossyDragon changed the title Wss Replace WebSocket connection handler Oct 16, 2024
@LossyDragon LossyDragon merged commit f70cd9d into Longi94:master Oct 16, 2024
1 check passed
@LossyDragon LossyDragon deleted the wss branch October 16, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant