feat: Simplify usage of ListenerService API - MEED-7009 - Meeds-io/meeds#2116 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eds#2116 **Is your feature request related to a problem? Please describe.** Using current implementation of `ListenerService`, it's difficult to trigger and to add event listeners. In fact the source code is very noisy when handling `ListenerService`, by example - to add a Listener: ```java listenerService.addListener("event.to.catch", new EventListener<> { public void onEvent(Event<S, D> event) { // Code .... } }); ``` - to trigger an event: ```java try { listenerService.broadcast("", s, d); } catch(Exception e) { .... } ``` This change will use `@FuntionalInterface` behavior to allow using Lambda expressions and avoid having to catch a checked exception while broadcasting event.
|
MayTekayaa
approved these changes
Jun 6, 2024
exo-swf
pushed a commit
that referenced
this pull request
Jun 6, 2024
…eds#2116 (#64) **Is your feature request related to a problem? Please describe.** Using current implementation of `ListenerService`, it's difficult to trigger and to add event listeners. In fact the source code is very noisy when handling `ListenerService`, by example - to add a Listener: ```java listenerService.addListener("event.to.catch", new EventListener<> { public void onEvent(Event<S, D> event) { // Code .... } }); ``` - to trigger an event: ```java try { listenerService.broadcast("", s, d); } catch(Exception e) { .... } ``` This change will use `@FuntionalInterface` behavior to allow using Lambda expressions and avoid having to catch a checked exception while broadcasting event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using current implementation of
ListenerService, it's difficult to trigger and to add event listeners. In fact the source code is very noisy when handlingListenerService, by exampleThis change will use
@FuntionalInterfacebehavior to allow using Lambda expressions and avoid having to catch a checked exception while broadcasting event.(Resolves Meeds-io/meeds#2116)