fix: correct color order for tip labels and enable to change tip labels #234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coloring by
fac
argument was incorrect because the order of the factors returned by thefac_dipatcher
function was different from the order of the tips(leaves) in dendrograms, which has been corrected. Also, the code for changing tip labels byfac
and/orlabels
arguments was ineffective, which has been corrected.background
When I was coloring tip labels by
fac
argument inCLUST
function, I noticed that the coloring is constant regardless of the topology of dendrograms. As an example, I ran the following code and found that there was a discrepancy between the tip labels and the colors.This may be due to the fact that the following code specifies the return value of
fac_dispatcher
as it is, when it should specify the colors in the same order as tip labels.Also, the following code seems to intend to change labels appropriately when
fac
orlabels
arguments are specified, but to no effect. It seems that this needs to be corrected appropriately as well.