forked from lambdaclass/cairo-vm
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ft/fix max high #47
Merged
HermanObst
merged 2 commits into
notlesh/segment-arena-relocation-fix
from
ft/fix_max_high
Oct 17, 2024
Merged
Ft/fix max high #47
HermanObst
merged 2 commits into
notlesh/segment-arena-relocation-fix
from
ft/fix_max_high
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results for unmodified programs 🚀
|
9 tasks
HermanObst
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don like it too much. But lets go
HermanObst
merged commit Oct 17, 2024
01ea1e0
into
notlesh/segment-arena-relocation-fix
32 of 69 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAX_HIGH and MAX_LOW constants were not found in
split_felt
hint. The path that was used to search for the variables seems to be wrong yet they are not on theconstant
hash map.So, this PR includes a fix for that and also a default value that matches cairo code