Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ BSP stop storing functionality and hooking up pallets in runtime #15

Merged
merged 20 commits into from
Mar 22, 2024
Merged

feat: ✨ BSP stop storing functionality and hooking up pallets in runtime #15

merged 20 commits into from
Mar 22, 2024

Conversation

snowmead
Copy link
Contributor

@snowmead snowmead commented Mar 19, 2024 •
edited
Loading

This PR introduces the following features:

  • Add storage providers and proofs-dealer pallets to runtime
  • Add storage providers and proofs-dealer pallets to file system pallet mock runtime
  • Add hard dependency on proofs-dealer in file system pallet (can be modified later to be loosely couple)
  • Add impl TrieVerifier in storage providers pallet with TODO
  • bsp_stop_storing (wip: challenge bsp will be implemented in another pr)
  • user multiple multiaddresses for a storage request
  • data_server_sps enables the possibilities for other storage providers to serve the file based for a storage request
  • Fixed weight write check for on_idle execution
  • Update unit tests

@snowmead snowmead marked this pull request as ready for review March 20, 2024 14:19
@snowmead snowmead changed the title BSP stop storing functionality BSP stop storing functionality and hooking up pallets in runtime Mar 20, 2024
@snowmead snowmead requested review from TDemeco and ffarall and removed request for TDemeco March 20, 2024 17:04
TDemeco
TDemeco requested changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@TDemeco TDemeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a change regarding the verifier

pallets/providers/src/lib.rs Outdated Show resolved Hide resolved
pallets/providers/Cargo.toml Outdated Show resolved Hide resolved
pallets/file-system/src/lib.rs Show resolved Hide resolved
@ffarall ffarall changed the title BSP stop storing functionality and hooking up pallets in runtime feat(runtime): ✨ BSP stop storing functionality and hooking up pallets in runtime Mar 21, 2024
ffarall
ffarall requested changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@ffarall ffarall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still pending review for:

  • bencharmking
  • mock
  • tests
  • types
  • utils

runtime/Cargo.toml Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
pallets/providers/src/lib.rs Show resolved Hide resolved
pallets/proofs-dealer/Cargo.toml Outdated Show resolved Hide resolved
pallets/proofs-dealer/src/lib.rs Show resolved Hide resolved
pallets/file-system/src/lib.rs Outdated Show resolved Hide resolved
pallets/file-system/src/lib.rs Outdated Show resolved Hide resolved
pallets/file-system/src/lib.rs Show resolved Hide resolved
pallets/file-system/src/lib.rs Outdated Show resolved Hide resolved
pallets/file-system/src/lib.rs Outdated Show resolved Hide resolved
@snowmead snowmead added enhancement New feature or request runtime labels Mar 21, 2024
@snowmead snowmead changed the title feat(runtime): ✨ BSP stop storing functionality and hooking up pallets in runtime feat: ✨ BSP stop storing functionality and hooking up pallets in runtime Mar 21, 2024
@snowmead
amend review; use mock verifier, remove proofs dealer impl and extrac…
a03efd2 
…t it into its own struct, revert whitespace change,
@notion-workspace Notion Workspace
Copy link

Implement bps_stop_storing

ffarall
ffarall requested changes Mar 21, 2024
View reviewed changes
pallets/file-system/src/types.rs Show resolved Hide resolved
pallets/file-system/src/utils.rs Show resolved Hide resolved
pallets/file-system/src/utils.rs Outdated Show resolved Hide resolved
@ffarall ffarall self-requested a review March 21, 2024 18:46
@ffarall ffarall self-requested a review March 21, 2024 23:26
ffarall
ffarall approved these changes Mar 21, 2024
View reviewed changes
pallets/file-system/src/lib.rs Show resolved Hide resolved
@snowmead @ffarall
Update pallets/file-system/src/lib.rs
a8f7f05 
Co-authored-by: Facundo Farall <37149322+ffarall@users.noreply.github.com>
@snowmead snowmead self-assigned this Mar 22, 2024
TDemeco
TDemeco approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@TDemeco TDemeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the changes 💯

@snowmead snowmead merged commit 109ae75 into main Mar 22, 2024
4 checks passed
@snowmead snowmead deleted the feat/bsp-stop-storing branch March 22, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TDemeco TDemeco TDemeco approved these changes

@ffarall ffarall ffarall approved these changes

Assignees

@snowmead snowmead

Labels
enhancement New feature or request runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snowmead @ffarall @TDemeco