-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out packages #1260
Split out packages #1260
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1260 +/- ##
=======================================
- Coverage 17% 17% -0%
=======================================
Files 229 226 -3
Lines 6953 6903 -50
=======================================
- Hits 1154 1141 -13
+ Misses 5799 5762 -37 |
9df5361
to
dc495fc
Compare
add simple readme
1a78070
to
c2f249e
Compare
I migrated a few simple widgets to the new package, just for demo purposes. |
Ah, TODO last thing: setup formatting and linting checks for I don't have a strong opinion on Melos (see previous convo), so if any of you would like to learn this tool, feel free to set it up – or I can do it myself (just not today). |
Great job here! Good idea to kickstart this next super important phase. Can you rebase this so we can merge it? @bartekpacia |
Wow, that's a lot of merge conflicts. |
Yeah, I guess we can just redo this with the updated develop |
Just a comment on the packages names: I prefer just |
Closed by #1282 |
This PR is a first step toward #1255
Subsequent action item is to progressively move widgets from
uni_app
touni_common_ui
- or just write design system components inuni_common_ui
.