Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out packages #1260

Closed
wants to merge 4 commits into from
Closed

Split out packages #1260

wants to merge 4 commits into from

Conversation

bartekpacia
Copy link
Collaborator

This PR is a first step toward #1255

Subsequent action item is to progressively move widgets from uni_app to uni_common_ui - or just write design system components in uni_common_ui.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17%. Comparing base (5176491) to head (c2f249e).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1260   +/-   ##
=======================================
- Coverage       17%     17%   -0%     
=======================================
  Files          229     226    -3     
  Lines         6953    6903   -50     
=======================================
- Hits          1154    1141   -13     
+ Misses        5799    5762   -37     

@bartekpacia bartekpacia marked this pull request as ready for review July 2, 2024 14:51
@bartekpacia
Copy link
Collaborator Author

I migrated a few simple widgets to the new package, just for demo purposes.

@bartekpacia
Copy link
Collaborator Author

Ah, TODO last thing: setup formatting and linting checks for packages/uni_common_ui as well.

I don't have a strong opinion on Melos (see previous convo), so if any of you would like to learn this tool, feel free to set it up – or I can do it myself (just not today).

@DGoiana
Copy link
Collaborator

DGoiana commented Jul 20, 2024

Great job here! Good idea to kickstart this next super important phase. Can you rebase this so we can merge it? @bartekpacia

@bartekpacia
Copy link
Collaborator Author

Wow, that's a lot of merge conflicts.

@DGoiana
Copy link
Collaborator

DGoiana commented Jul 20, 2024

Wow, that's a lot of merge conflicts.

Yeah, I guess we can just redo this with the updated develop

@thePeras
Copy link
Member

Just a comment on the packages names: I prefer just uni and ui / uni_ui

@DGoiana DGoiana mentioned this pull request Jul 23, 2024
7 tasks
@DGoiana
Copy link
Collaborator

DGoiana commented Jul 23, 2024

Closed by #1282

@DGoiana DGoiana closed this Jul 23, 2024
@bartekpacia bartekpacia deleted the refactor/package_split_1 branch July 23, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants