Skip to content

Commit

Permalink
Lint and typo fix
Browse files Browse the repository at this point in the history
- targets_download.R: duplicate target names
- Roxygen2 documentation typo fix in fit_base_lightgbm
  • Loading branch information
Insang Song committed Jul 16, 2024
1 parent 716ede2 commit 24e7376
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
4 changes: 2 additions & 2 deletions R/pipeline_base_functions.R
Original file line number Diff line number Diff line change
Expand Up @@ -2573,7 +2573,7 @@ fit_base_xgb <-
# dtfitx <- fit_base_xgb(dtd, xvar = names(dtd)[6:105], r_subsample = 0.3)


' Base learner: Light Gradient Boosting Machine (LightGBM)
#' Base learner: Light Gradient Boosting Machine (LightGBM)
#'
#' LightGBM model is fitted at the defined rate (`r_subsample`) of
#' the input dataset by grid or Bayesian optimization search.
Expand Down Expand Up @@ -3697,7 +3697,7 @@ restore_fit_best <-
)

# fit the entire data
model_fit <- fit(model_best, data = df_full)
model_fit <- parsnip::fit(model_best, data = df_full)
pred <- predict(model_fit, data = df_full)
return(pred)

Expand Down
6 changes: 3 additions & 3 deletions inst/targets/targets_download.R
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
target_download <-
list(
tarchetypes::tar_files_input(
name = file_prep_calc_args,
name = file_prep_download_args,
files = list.files("inst/targets", pattern = "download_spec.qs$", full.names = TRUE),
# cue = tar_invalidate(tar_older(Sys.time() - as.difftime(4, units = "weeks"))),
format = "file",
Expand Down Expand Up @@ -30,9 +30,9 @@ target_download <-
lgl_rawdir_download,
command =
feature_raw_download(
path = file_prep_calc_args,
path = file_prep_download_args,
dataset_name = char_rawdir_download),
pattern = map(file_prep_calc_args, char_rawdir_download),
pattern = map(file_prep_download_args, char_rawdir_download),
iteration = "list"
)
)
Expand Down
5 changes: 1 addition & 4 deletions man/fit_base_lightgbm.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 24e7376

Please sign in to comment.