Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calc_* and process_hms functions; .gitignore #264

Merged
12 commits merged into from
Jan 23, 2024
Merged

calc_* and process_hms functions; .gitignore #264

12 commits merged into from
Jan 23, 2024

Conversation

mitchellmanware
Copy link
Collaborator

I was unable to resolve errors in previous pull requests, so with new branch (v2) I will commit small changes to evaluate how they do/do not pass pull request tests.

@mitchellmanware
Copy link
Collaborator Author

@Spatiotemporal-Exposures-and-Toxicology

All checks are failing due to:

 Error: 
  ! error in pak subprocess
  Caused by error in `verify_extracted_package(filename, pkg_cache)`:
  ! 
  '/tmp/RtmpyxpY6v/file13cf7aaebd0c/src/contrib/x86_64-pc-linux-gnu-ubuntu-22.04/4.3/withr_3.0.0.tar.gz'
  is not a valid binary, it is missing withr/Meta/package.rds.
  ---
  Backtrace:
  1. pak::lockfile_install(".github/pkg.lock")
  2. pak:::remote(function(...) { …
  3. err$throw(res$error)

Unclear why this is occurring, and seems weird that 4 R files (which pass local lints and are not subject to testing) and edits to the .gitignore cause these issues. Do you have any idea why this is happening?

@kyle-messier
Copy link
Collaborator

@mitchellmanware Not sure why. Did you need to add all of those sub-paths to the .gitignore?

@mitchellmanware
Copy link
Collaborator Author

@Spatiotemporal-Exposures-and-Toxicology
Those are the folders with raw covariate data, but I guess those can be put into one single raw_data/ folder and have just that on the .gitignore.

@mitchellmanware
Copy link
Collaborator Author

mitchellmanware commented Jan 17, 2024

Seems to be an issue with the new version of the withr package published yesterday. GitHub dialogue has opened for fixes- I will keep updating.

Package- https://cran.r-project.org/web/packages/withr/index.html
Discussion- r-lib/withr#253

@Spatiotemporal-Exposures-and-Toxicology @sigmafelix @eva0marques @dzilber @MAKassien @dawranadeep @Sanisha003

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (b1273f3) 91.06% compared to head (5c6233c) 91.78%.

Files Patch % Lines
R/download.R 91.72% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   91.06%   91.78%   +0.72%     
==========================================
  Files          14       14              
  Lines        1735     1839     +104     
==========================================
+ Hits         1580     1688     +108     
+ Misses        155      151       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitchellmanware
Copy link
Collaborator Author

mitchellmanware commented Jan 18, 2024

  • R-CMD-check build finally passes due to updates to withr package.
  • URL checks within download functions are not covered by unit tests
  • pkgdown fail- may be due to .qmd file in vignettes
    • Note: pkgdown does not like Quarto documents for vignettes

@mitchellmanware
Copy link
Collaborator Author

URLs generated by download_sedac* always return HTTP status 200 because the httr::GET() returns the NASA EarthData login page. Removed for now but will continue to work on these within function URL checks.

@sigmafelix sigmafelix mentioned this pull request Jan 19, 2024
@sigmafelix sigmafelix closed this pull request by merging all changes into main in 6acbb8f Jan 23, 2024
@mitchellmanware mitchellmanware deleted the mm-calc-functions-v2 branch January 23, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants