Revert "Testdata creation"

[kyle-messier]

Reverts #290

[kyle-messier]

@eva0marques The merging of the test dataset creation has caused errors in test-coverage and R-CMD-check. Can you check the 3 failed tests? I tried reverting, but not working. @sigmafelix also if want to resolve. Thanks!

[sigmafelix]

@kyle-messier @eva0marques I will investigate the issue.

[eva0marques]

I do not remember why this pull request was not closed but it sounds that some tests about cross validation are no longer valid. I guess it is because @insang you improved the code in that script and merge to main branch? Maybe we can just remove this cross validation file from my pull request? Sorry about that.

[sigmafelix]

@eva0marques I checked out this branch and all tests in the problem passed in my end. I cleared GitHub Action cache and am rerunning the tests now.

[eva0marques]

Nice, thanks.

[eva0marques]

@sigmafelix I have no clue now, I copy the same cross validation functions and tests as main branch and still have troubles to pass the checks 🤔

[eva0marques]

@sigmafelix I'm updating test-temporal-range, that might be the problem...

[sigmafelix]

@eva0marques I couldn't figure out what the problem exactly is. I changed the global set.seed part into withr::local_seed in this trial. Let's see what happens.

[eva0marques]

I hope that merging this branch into main won't remove work done on main branch since then.

[eva0marques]

I just realized that this pull request erased my script create_testdata.R for test data creation.

[kyle-messier]

@eva0marques @sigmafelix R CMD and test-coverage are both failing beacuse of 3 failed tests:

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test-cross_validation.R:61:3'): leave-ones run without errors ─────
max(index_loto) not equal to tlength.
1/1 mismatches
[1] NA - 10 == NA
── Failure ('test-temporal_range.R:17:3'): covariates are within temporal range. ──
all(iswithin) not equal to TRUE.
1 element mismatch
── Failure ('test-temporal_range.R:27:3'): test_nc_output.nc is within temporal range. ──
all(iswithin) not equal to TRUE.
1 element mismatch

[eva0marques]

@kyle-messier we see that but we don't understand why.

[sigmafelix]

@kyle-messier @eva0marques Couldn't reproduce errors in my end. As a drastic measure, I removed generate_cv_index and its upstream dependencies, temporal range check, and base learners from the codebase. The cv index functions and base learners are not critical at this moment (possibly not in the future, I believe) as we distributed base learner development tasks to teams. I think temporal range check is controlled in the pipeline level, so we will be fine without it.

[eva0marques]

I trust you @sigmafelix lol