Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.4.1 #360

Merged
merged 21 commits into from
Sep 25, 2024
Merged

0.4.1 #360

merged 21 commits into from
Sep 25, 2024

Conversation

mitchellmanware
Copy link
Collaborator

Branch includes thorough unit testing of all beethoven functions, and a reorganization of tests/testthat/ folder. Branch also includes initial development of model prediction functions and prediction grid covariate development, but both are incomplete.

Notes

  • mlp and lightGBM base learner models are not tested due to ongoing torch installation problems
  • Base learner performance tests (ie. mean, SD, range) tests are currently disabled
  • Incomplete development of prediction grid covariates

@mitchellmanware
Copy link
Collaborator Author

testthat::skip_on_ci added to par_narr unit tests due to gdal mismatch. Default version of gdal in GitHub actions is not recognizing the subsetted netCDF as valid, and is therefore causing errors with the tests. Local testing runs and passes. I will update the workflow to install proper version of gdal after more information from Frank.

testthat::skip_on_ci added to inject_calculat(nei) unit tests. I do not know why the GitHub actions test is failing. Passes locally and error information says there is an improper list, which is not true. Skipped for now to ensure main code base is in the main branch, but will update after.

── Failure ('test-injection.R:192:3'): inject_calc (hms + nei) ─────────────────
Expected `... <- NULL` to run without any errors.
ℹ Actually got a <simpleError> with text:
  Error in colnames(csvs_nei)[target_cns] <- c("geoid", "emissions_total", : invalid subscript type 'list'
  
  function (path = NULL, county = NULL, year = c(2017, 2020), ...) 
  NULL
  Please refer to the argument list and the error message above to rectify the error.
  
── Error ('test-injection.R:205:3'): inject_calc (hms + nei) ───────────────────
Error in `eval(code, test_env)`: object 'nei_injected' not found
Backtrace:
    ▆
 1. └─testthat::expect_true(is.list(nei_injected)) at test-injection.R:205:3
 2.   └─testthat::quasi_label(enquo(object), label, arg = "object")
 3.     └─rlang::eval_bare(expr, quo_get_env(quo))

@kyle-messier kyle-messier merged commit 106e194 into main Sep 25, 2024
4 checks passed
@mitchellmanware mitchellmanware deleted the mm-tests-0820 branch September 30, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants