CI update to fix broken Docker image #7
Merged
+369
−57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While troubleshooting an unusual sequencing run, I recently encountered an issue where both
umi-tools dedup
andUMICollapse
crashed due to an extraordinarily high number of UMIs (>1e5) at a single position.However, I recalled that you were working on another deduplication software,
rumidup
, and wanted to test, your tool could still handle this dataset. Unfortunately, when I tried pulling the Docker image from GHCR, I realized it no longer works:The issue lies on my end, as two years ago I made the unfortunate decision to build it on the latest Rust image, which uses the current Debian
stable
release, but to run it on an image pinned to Debian Bullseye, which is now onlyoldstable
. Hence, it is compiled against a newer GLIBC than available on the runner.This PR proposes a fixed Dockerfile and upgraded GitHub Actions that include one to build binaries of your tool directly as release assets. I hope this helps and made separate commits for each, so you can git cherry pick from a different branch than
master
, which one(s) you like.PS: Thank you so much for creating this tool! I hope you’ll release an official first version soon. Don’t forget to link the GitHub repository to Zenodo beforehand, so a citable record is automatically generated upon making a release on GitHub. If you’d like, feel free to adapt our Bioconda recipe from umi-transfer to rumidup to get it on Bioconda as well — I believe it should work with only minor adjustments!