implement restart for internal tides #463
Conversation
raphaeldussin
commented
Aug 18, 2023
•
raphaeldussin
commented
- add a call to register restart diabatic in MOM
- register restart diabatic call register restart internal tides
- internal tides restart uses the extra_axes optional argument
- support for extra_axes added to MOM_restart/MOM_io
- support for 4d array read with FMS1
- works with FMS2
- writes 4d restarts for horizontal, propagation angle and tidal frequency
- writes 5 restart variables for all the propagating vertical modes
* add a call to register restart diabatic in MOM * register restart diabatic call register restart internal tides * internal tides restart uses the extra_axes optional argument * support for extra_axes added to MOM_restart/MOM_io
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #463 +/- ##
============================================
- Coverage 38.04% 38.01% -0.03%
============================================
Files 270 270
Lines 77637 77764 +127
Branches 14285 14320 +35
============================================
+ Hits 29538 29564 +26
- Misses 42783 42876 +93
- Partials 5316 5324 +8
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
* passes global_file optional arg to allow reading in parallel restart files
vertical modes >= 6 do not propagate hence there is no need for dynamic array size on this dimension
There was a problem hiding this comment.
Extending restart registration to set the global_file flag seems to me to be a very good solution to me for supporting potentially domain-decomposed 4d restarts.
It does revert some of the effort to transition control structures from pointers to stack variable, but this can be handled for now.
I have included some minor comments which should finalize this PR, and we can merge it ASAP.
raphaeldussin
force-pushed
the
restart_internal_tides
branch
from
3b882ff
to
b7852ce
Compare
raphaeldussin
force-pushed
the
restart_internal_tides
branch
from
b7852ce
to
5405c3b
Compare
