Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Run test (and test.summary) locally #473

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

marshallward
Copy link
Member

The test.summary rule was causing errors in our Gitlab testing due to multiple runs (concurrent or otherwise) in the same workspace directory. This patch removes the WORKSPACE directory variable, and each .testing run happens in its own directory.

Other minor changes:

  • The script to generate the summary was moved out of the Makefile and into a separate script.

  • Unrelated to these changes, error output was extended from 20 to 40 lines, to provide more readable backtrace output.

The test.summary rule was causing errors in our Gitlab testing due to
multiple runs (concurrent or otherwise) in the same workspace directory.
This patch removes the WORKSPACE directory variable, and each .testing
run happens in its own directory.

Other minor changes:

- The script to generate the summary was moved out of the Makefile and
  into a separate script.

- Unrelated to these changes, error output was extended from 20 to 40
  lines, to provide more readable backtrace output.
@marshallward
Copy link
Member Author

This is a repeat of #462, I believe it now addresses the major issue.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #473 (35a9950) into dev/gfdl (1bb8852) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 35a9950 differs from pull request most recent head 704d6a2. Consider uploading reports for the commit 704d6a2 to get more accurate results

@@             Coverage Diff              @@
##           dev/gfdl     #473      +/-   ##
============================================
- Coverage     38.01%   38.01%   -0.01%     
============================================
  Files           270      270              
  Lines         77765    77765              
  Branches      14321    14321              
============================================
- Hits          29564    29563       -1     
  Misses        42876    42876              
- Partials       5325     5326       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marshallward
Copy link
Member Author

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/20580 ✔️

@marshallward marshallward merged commit d342b29 into NOAA-GFDL:dev/gfdl Sep 11, 2023
10 checks passed
@marshallward marshallward deleted the make_test_summary_fix branch May 8, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants