Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ice-shelf diagnostics #728

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Conversation

alex-huth
Copy link

New diagnostics for ice-shelf flux divergence, strain-rates, deviatoric stresses, speed, surface slope magnitude, and driving stress magnitude. Fixed some misleading units for variables related to ice viscosity

…es, and ice speed; and the magnitude of ice surface slope and driving stress. Fixed some misleading units for variables related to ice viscosity
Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These added diagnostics and corrected comments seem valuable, but this PR uses potentially dangerous array syntax calculations. Such array syntax calculations are strongly discouraged in MOM6, as discussed at https://github.com/NOAA-GFDL/MOM6/wiki/Code-style-guide#array-syntax . Please revise this PR to avoid the use of explicit array syntax math or implied array syntax math in the arguments to the post_data calls.

…ics. Also fixed incorrect loop bounds for a seldom-used ice-shelf convergence criterion
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.88%. Comparing base (ba59078) to head (b0aadcb).
Report is 10 commits behind head on dev/gfdl.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev/gfdl     #728      +/-   ##
============================================
+ Coverage     36.67%   40.88%   +4.21%     
============================================
  Files           274       42     -232     
  Lines         83858     5288   -78570     
  Branches      15761     1013   -14748     
============================================
- Hits          30754     2162   -28592     
+ Misses        47326     2941   -44385     
+ Partials       5778      185    -5593     
Flag Coverage Δ
40.88% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes now look correct to me.

@marshallward
Copy link
Member

Gaea regression: CM4_piControl_c192_OM4p25_bench ✔️

@marshallward marshallward merged commit b240e7e into NOAA-GFDL:dev/gfdl Oct 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants