Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bnb/meta enum #451

Merged
merged 63 commits into from
May 30, 2024
Merged

Bnb/meta enum #451

merged 63 commits into from
May 30, 2024

Conversation

bnb32
Copy link
Collaborator

@bnb32 bnb32 commented May 13, 2024

hardcoded strings replaced with enumerated aliases from reV.utilities.MetaKeyName

@bnb32 bnb32 marked this pull request as ready for review May 13, 2024 16:41
@bnb32 bnb32 requested a review from ppinchuk May 13, 2024 16:41
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

Attention: Patch coverage is 83.61995% with 381 lines in your changes are missing coverage. Please review.

Project coverage is 87.32%. Comparing base (e1d6163) to head (b267dac).

Files Patch % Lines
reV/qa_qc/qa_qc.py 14.70% 58 Missing ⚠️
reV/qa_qc/summary.py 37.36% 57 Missing ⚠️
reV/supply_curve/points.py 77.14% 32 Missing ⚠️
reV/rep_profiles/rep_profiles.py 80.00% 25 Missing ⚠️
reV/generation/base.py 78.00% 22 Missing ⚠️
reV/supply_curve/aggregation.py 76.00% 18 Missing ⚠️
reV/supply_curve/sc_aggregation.py 80.00% 17 Missing ⚠️
reV/SAM/generation.py 92.88% 16 Missing ⚠️
reV/nrwal/nrwal.py 80.95% 16 Missing ⚠️
reV/supply_curve/extent.py 42.85% 16 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
+ Coverage   87.27%   87.32%   +0.05%     
==========================================
  Files         122      122              
  Lines       17425    17498      +73     
==========================================
+ Hits        15208    15281      +73     
  Misses       2217     2217              
Flag Coverage Δ
unittests 87.32% <83.61%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk merged commit 081d70e into main May 30, 2024
11 checks passed
@ppinchuk ppinchuk deleted the bnb/meta_enum branch May 30, 2024 19:07
github-actions bot pushed a commit that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants