Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BOS cost to bespoke optimization #453

Merged
merged 12 commits into from
May 31, 2024
Merged

Add BOS cost to bespoke optimization #453

merged 12 commits into from
May 31, 2024

Conversation

ppinchuk
Copy link
Collaborator

This PR adds the capability to specify a BOS cost for the bespoke optimization.

Three distances are allowed: avg_sl_dist_to_center_m, avg_sl_dist_to_medoid_m, and nn_conn_dist_m. The first two are self-explanatory. The last one is a simple greedy nearest-neighbor connection algorithm that gives connections that look something like this:

image

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.40%. Comparing base (081d70e) to head (beb1f69).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
+ Coverage   87.27%   87.40%   +0.12%     
==========================================
  Files         122      122              
  Lines       17484    17600     +116     
==========================================
+ Hits        15260    15383     +123     
+ Misses       2224     2217       -7     
Flag Coverage Δ
unittests 87.40% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk marked this pull request as ready for review May 30, 2024 21:59
@ppinchuk ppinchuk merged commit 43e22ac into main May 31, 2024
11 checks passed
@ppinchuk ppinchuk deleted the pp/bespoke_bos_cost branch May 31, 2024 02:45
github-actions bot pushed a commit that referenced this pull request May 31, 2024
Add BOS cost to bespoke optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants