Add resource length warning for easier debugging #457
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
=======================================
Coverage ? 87.57%
=======================================
Files ? 122
Lines ? 18086
Branches ? 0
=======================================
Hits ? 15839
Misses ? 2247
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Good addition. Maybe note "try setting 'time_index_step: 1' in your SAM config or double check the resource input you're using"
In the future i think there will be value in running monthly data to generate profiles for event analysis. SAM used to not be able to do that but i'm pretty sure now it can just the annual values will not be set (annual CF).
|
Ah good to know. Interested to see if reV can handle the monthly case out of the box or not. We should probably set up a test for that when it becomes relevant - might be a good time to re-evaluate this message too :) (Happy to take charge on that whenever it comes around) |
Add resource length warning for easier debugging
@grantbuster Reid recently ran into a tough-to-debug issue where SAM wasn't setting the output variables correctly, and it came down to the fact that he was using
time_index_step=2on hourly resource data.Since this was a tough problem to track down, I figured I would add a few warning messages if this case is detected. Any objections? Any reason why someone would want to run less than a full 8760 time series through SAM? Is that even allowed (seems like not based on this experience but I haven't fully tested that)?