Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bespoke cost fixes #464

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Bespoke cost fixes #464

merged 5 commits into from
Aug 16, 2024

Conversation

ppinchuk
Copy link
Collaborator

Site and base FOC and VOC now reported correctly if user provides multipliers in the project points file.

Also addresses #463

@ppinchuk ppinchuk added the bug Something isn't working label Aug 15, 2024
@ppinchuk ppinchuk self-assigned this Aug 15, 2024
@ppinchuk ppinchuk marked this pull request as ready for review August 15, 2024 22:57
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.69%. Comparing base (a27dc0a) to head (a7dbdcb).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   87.59%   87.69%   +0.10%     
==========================================
  Files         122      122              
  Lines       18109    18171      +62     
==========================================
+ Hits        15862    15935      +73     
+ Misses       2247     2236      -11     
Flag Coverage Δ
unittests 87.69% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk merged commit f4b0b40 into main Aug 16, 2024
11 checks passed
@ppinchuk ppinchuk deleted the pp/bespoke_cost_fixes branch August 16, 2024 00:48
github-actions bot pushed a commit that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants